Add Nix Flake - #945
Merged
Merged
Conversation
Adds a nix flake for building bldc firmware. This has been ported from the vesc_tool nix package for bldc.
This git_hash variable is unused. Remove it. This removes a dependency on git, allowing removal of a hack in bldc.nix.
Document the default flake build and point new users to the packaged firmware output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a nix flake to help make building easier and more consistent.
Test this locally with
nix build github:MilesBreslin/bldc/mbreslin/nix_init#bldc-fw. This has been tested on x86_64-linux and aarch64-darwin.While this is a port from vesc_tool, it builds on top of vedderb/vesc_tool#464. A follow-up to this PR will be a change in vesc_tool, which fully shifts the bldc nix definition into this repository.
An optional follow-up, if there is interest, would be a github workflow to add build testing for PRs.
flake.nix: Init
Adds a nix flake for building bldc firmware. This has been ported from
the vesc_tool nix package for bldc.
package_firmware.py: Remove git SHA logic
This
git_hashvariable is unused. Remove it. This removes a dependencyon git, allowing removal of a hack in bldc.nix.
README: add Nix quick start
Document the default flake build and point new users to the packaged
firmware output.